Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

list format in TOC #889

Merged
merged 1 commit into from
Feb 23, 2022
Merged

list format in TOC #889

merged 1 commit into from
Feb 23, 2022

Conversation

Austaras
Copy link

First-time contributors' checklist

What is changed, added, or deleted? (Required)

Which DM version(s) do your changes apply to? (Required)

Since December 23, 2021, the TiDB DM documentation in the master branch has been merged to TiDB documentation by #8042 and #7317. To create a PR for TiDB DM versions later than v5.3, either go to TiDB English documentation repository or Chinese documentation repository.

  • v5.3 (TiDB DM 5.3 versions)
  • v2.0 (TiDB DM 2.0 versions)
  • v1.0 (TiDB DM 1.0 versions)

What is the related PR or file link(s)?

  • This PR is translated from:
  • Other reference link(s):

Do your changes match any of the following descriptions?

  • Delete files
  • Change aliases
  • Need modification after applied to another branch
  • Might cause conflicts after applied to another branch

@ti-chi-bot
Copy link
Member

ti-chi-bot commented Feb 23, 2022 •
edited
Loading

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • shichun-0415

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@CLAassistant
Copy link

CLAassistant commented Feb 23, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@ti-chi-bot ti-chi-bot added missing-translation-status This PR does not have translation status info. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Feb 23, 2022
shichun-0415
shichun-0415 approved these changes Feb 23, 2022
View reviewed changes
Copy link
Contributor

@shichun-0415 shichun-0415 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot ti-chi-bot added the status/LGT1 Indicates that a PR has LGTM 1. label Feb 23, 2022
@shichun-0415 shichun-0415 added translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format. status/LGT2 Indicates that a PR has LGTM 2. and removed missing-translation-status This PR does not have translation status info. status/LGT1 Indicates that a PR has LGTM 1. labels Feb 23, 2022
@ti-chi-bot ti-chi-bot added status/LGT1 Indicates that a PR has LGTM 1. and removed status/LGT2 Indicates that a PR has LGTM 2. labels Feb 23, 2022
@shichun-0415
Copy link
Contributor

/remove status LGT1
/status LGT2

@ti-chi-bot ti-chi-bot added the status/LGT2 Indicates that a PR has LGTM 2. label Feb 23, 2022
@shichun-0415
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: 9a6c504

@ti-chi-bot ti-chi-bot added the status/can-merge Indicates a PR has been approved by a committer. label Feb 23, 2022
@ti-chi-bot ti-chi-bot merged commit 0002687 into release-5.3 Feb 23, 2022
@Austaras Austaras deleted the Austaras-patch-1 branch February 23, 2022 04:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shichun-0415 shichun-0415 shichun-0415 approved these changes

Assignees
No one assigned
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. status/can-merge Indicates a PR has been approved by a committer. status/LGT1 Indicates that a PR has LGTM 1. status/LGT2 Indicates that a PR has LGTM 2. translation/no-need The changes in this PR don't need to be translated. type/bug-fix Fixes typos or wrong format.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Austaras @ti-chi-bot @CLAassistant @shichun-0415